Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2022_KumarScience_Xinjiang.janno #206

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ainashch
Copy link

@ainashch ainashch commented Aug 15, 2024

.janno file for future use.

Kumar et al. Science Bronze and Iron Age population movements underlie Xinjiang population history 2022 https://www.science.org/doi/10.1126/science.abk1534

@nevrome nevrome added the only .janno This PR does not feature a full package, but only a .janno file label Aug 18, 2024
@stschiff
Copy link
Member

Great, thanks @ainashch. We'll take a look!

@nevrome
Copy link
Member

nevrome commented Sep 6, 2024

Thanks for preparing this .janno file! I see the following issues

  • The package name does not follow our expected standard of Year_AuthorName_RelevantKeyword. I propose 2022_Kumar_Xinjiang.
  • Please remove all columns that are completely empty/filled only with n/a.
  • The Relation_To column works with the Alternative_IDs, not the Poseidon_IDs. Is there a reason why there are two sample naming schemes existing in parallel? Why did you opt for the alternative one for the Relation_To column? I think there are multiple possible solutions to this.
  • It seems you used a combination of Relation_Degree == first + Relation_Type == identical to express that two samples are from the same individual. This is not necessary. Relation_Degree can be set to identical directly.
  • There is a site called G218 - just to make sure: This is a proper site name?
  • The last sample has the Site set to Unknown. I think it would be better to put it to n/a.
  • The Date_Type should be set to contextual for contextual ages. Date_Note then does not need the redundant *Date contextual (what does the * mean?).
  • Date_BC_AD_Median can be computed as the mean of Date_BC_AD_Start and Date_BC_AD_Stop for contextual ages.
  • The Publication column is typically used for a bibtex key in a complete package. In this .janno-only submission we can leave it like it is for now.

Maybe you could quickly have a look 👍

@nevrome nevrome self-assigned this Sep 6, 2024
@stschiff
Copy link
Member

stschiff commented Dec 3, 2024

@ainashch did you have a chance to look into this, or do you need help?

@stschiff
Copy link
Member

stschiff commented Dec 3, 2024

I will reach out to the first author and ask for genotype pulldown data.

@nevrome nevrome deleted the branch poseidon-framework:dev January 17, 2025 11:58
@nevrome nevrome closed this Jan 17, 2025
@stschiff
Copy link
Member

I have located the genotype data on the web. I will take over.

@stschiff stschiff assigned stschiff and unassigned nevrome Jan 31, 2025
@stschiff stschiff removed the only .janno This PR does not feature a full package, but only a .janno file label Jan 31, 2025
@nevrome nevrome reopened this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants