-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2023_VillaIslas_preHispanicMexico #205
Add 2023_VillaIslas_preHispanicMexico #205
Conversation
Super @jbv2, we'll take a look! Thanks! |
@jbv2 we were wondering whether you could perhaps reach out to the first author and ask for the genotype data to be added here? That would be ideal. We also happen to have the package no in the Minotaur archive, but author-provided genotype data would be welcome for this repository, too! |
Yes, I will write back here when I have an answer. |
Yes @stschiff |
Cool, thanks for that, @jbv2, let's hope we get the data soon. |
@stschiff I just got the hg19 plink files. Can someone guide me on what to do next? |
Great that this came together, finally! I added the usual checklist to your comment above, @jbv2. Maybe you could quickly go through that check the boxes. When this is done I'll try to find a reviewer. I already have a quick review comment about the package name: I think we should avoid |
@nevrome thanks. I renamed the package and made some minor changes to check all the boxes. |
@martynamolak Your submission (#253) just got reviewed. Would you, in turn, be available to have a brief look at this package? Specifically the .janno, .bib, and .yml file? Feel free to decline if you're not, at the moment. |
@nevrome , sorry the message slipped somehow and only read it now. |
Hi, This is my first time reviewing a Poseidon package so I hope I will make any sense here.
I hope I haven't missed too many things. Also, hope I didn't pick on too many things that didn't really need to be addressed. |
Thank you for this thorough review, @martynamolak! Some quick comments:
@jbv2 I hope these ToDos are feasible. Feel free to address them when you have time. |
@jbv2 Quick reminder that this is still open. Are the ToDos clear or do you have some open questions? Happy to help 👍 |
…ed: convert to Git LFS
…e same as Toluquilla)
…rovided by author
Ok, sorry for the delay @nevrome, and thanks for the comments @martynamolak !
Please let me know if you need anything else. |
Perfect! Thank you for the clean update. I set the version number to 1.0.0 and will merge now. |
PR Checklist for a new package submission
POSEIDON.yml
conforms to the general title structure suggested here:<Year>_<Last name of first author>_<Region, time period or special feature of the paper>
, e.g.2021_Zegarac_SoutheasternEurope
,2021_SeguinOrlando_BellBeaker
or2021_Kivisild_MedievalEstonia
.POSEIDON.yml
file with not just the file-referencing fields, but also the following meta-information fields present and filled:poseidonVersion
,title
,description
,contributor
,packageVersion
,lastModified
(see here for their definition).janno
file (for a list of available fields look here and here for more detailed documentation about them)..bib
file with the necessary literature references for each sample in the.janno
file.POSEIDON.yml
file and there are no additional, supplementary files in the submission that are not documented there..janno
and.bib
file are all named after the package title and only differ in the file extension.POSEIDON.yml
file is1.0.0
.poseidonVersion
of the package in thePOSEIDON.yml
file is set to the latest version of the Poseidon schema.POSEIDON.yml
file contains the corresponding checksums for the fieldsgenoFile
,snpFile
,indFile
,jannoFile
andbibFile
.CHANGELOG
file or one with a single entry for version1.0.0
.Publication
column in the.janno
file is filled and the respective.bib
file has complete entries for the listed mentioned keys..janno
file does not include any empty columns or columns only filled withn/a
..janno
file adheres to the standard order as defined in the Poseidon schema here..janno
and the.ssf
files are not fully quoted, so they only use single- or double quotes ("..."
,'...'
) to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).trident validate --fullGeno
.git lfs migrate import --no-rewrite path/to/file.bed
(see here).