-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create 2023_Rodriguez_Varela.janno #198
base: dev
Are you sure you want to change the base?
Create 2023_Rodriguez_Varela.janno #198
Conversation
Thanks for preparing this .janno file! I see the following issues
Maybe you could quickly have a look 👍. Please run |
Add Country_ISO column add kinship info Fix Genetic_Sex formatting Remove incomplete Contamination information Update UDG information and note
I renamed the janno file, but cannot rename the directory on GH. @Helsinki-Ronan , maybe you could rename the directory on your fork to |
@Helsinki-Ronan could you perhaps reach out to Anders or the first author of this paper and ask them for the genotype data for this package? We would like author-made genotype data for this repository, not the one from AADR. Thanks! |
@TCLamnidis I just synced my fork with yours (Poseidon's) and the package appears as 2023_RodriguezVarela_Scandinavia so I guess you renamed it yourself? @stschiff I'm not sure what you mean. The data is from ENA, not from AADR. Or do they both point to the same thing? |
@Helsinki-Ronan The files I could rename, but not the directory |
OK, so what I meant was: In order to elevate this Janno-file, which you kindly prepared, to a package, we need Genotype data. Either we transfer this Janno over to Minotaur and generate it ourselves from the raw data on ENA, or we ask the original authors to share 1240K genotype with us. Both is possible, we just need to decide. I thought that perhaps it's worth a shot to reach out to Anders Götherström and the first author and ask them. I'm happy to do so myself, shoud I, or would you want to try, @Helsinki-Ronan? I'm just asking because you are the current assignee for this package so you can decide. |
this package has a minotaur archive PR pending, and the provided janno was used there already (and even supplemented). |
.janno file for future use.