Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2023_Rodriguez_Varela.janno #198

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

Helsinki-Ronan
Copy link

@Helsinki-Ronan Helsinki-Ronan commented Aug 15, 2024

.janno file for future use.

Rodríguez-Varela et al. 2023 Cell The genetic history of Scandinavia from the Roman Iron Age to the present 2023 https://doi.org/10.1016/j.cell.2022.11.024

@nevrome nevrome added the only .janno This PR does not feature a full package, but only a .janno file label Aug 18, 2024
@nevrome
Copy link
Member

nevrome commented Aug 18, 2024

Thanks for preparing this .janno file! I see the following issues

  • The package name does not follow our expected standard of Year_AuthorName_RelevantKeyword. I propose 2023_RodriguezVarela_Scandinavia.
  • Please remove all columns that are completely empty/filled only with n/a.
  • The Genetic_Sex must be one of F, M or U.
  • If Contamination and Contamination_Err are empty then Contamination_Meas must be empty as well.
  • Date_Type must be C14, not c14.
  • If Date_Type == C14, then Date_C14_Uncal_BP and Date_C14_Uncal_BP_Err can not be empty.
  • The Source_Tissue ancient_human_skeletal_element is not very informative. If the paper does not specify further, e.g. by distinguishing bone or teeth, then I suggest to leave the column empty and remove it.
  • The note reads Data are a mix of UDG-treated and untreated libraries. Cannot find information as to which libraries are UDG-half or UDG-full Setting udg to “minus”. @TCLamnidis

Maybe you could quickly have a look 👍. Please run trident validate --janno on the file after you implemented the necessary changes.

    Add Country_ISO column
    add kinship info
    Fix Genetic_Sex formatting
    Remove incomplete Contamination information
    Update UDG information and note
@TCLamnidis
Copy link
Member

I renamed the janno file, but cannot rename the directory on GH. @Helsinki-Ronan , maybe you could rename the directory on your fork to 2023_RodriguezVarela_Scandinavia?

@stschiff
Copy link
Member

stschiff commented Dec 3, 2024

@Helsinki-Ronan could you perhaps reach out to Anders or the first author of this paper and ask them for the genotype data for this package? We would like author-made genotype data for this repository, not the one from AADR. Thanks!

@Helsinki-Ronan
Copy link
Author

@TCLamnidis I just synced my fork with yours (Poseidon's) and the package appears as 2023_RodriguezVarela_Scandinavia so I guess you renamed it yourself?

@stschiff I'm not sure what you mean. The data is from ENA, not from AADR. Or do they both point to the same thing?

@TCLamnidis
Copy link
Member

@Helsinki-Ronan The files I could rename, but not the directory

@nevrome nevrome deleted the branch poseidon-framework:dev January 17, 2025 11:58
@nevrome nevrome closed this Jan 17, 2025
@stschiff stschiff removed the only .janno This PR does not feature a full package, but only a .janno file label Jan 31, 2025
@nevrome nevrome reopened this Feb 1, 2025
@stschiff
Copy link
Member

stschiff commented Feb 3, 2025

OK, so what I meant was: In order to elevate this Janno-file, which you kindly prepared, to a package, we need Genotype data. Either we transfer this Janno over to Minotaur and generate it ourselves from the raw data on ENA, or we ask the original authors to share 1240K genotype with us. Both is possible, we just need to decide. I thought that perhaps it's worth a shot to reach out to Anders Götherström and the first author and ask them. I'm happy to do so myself, shoud I, or would you want to try, @Helsinki-Ronan? I'm just asking because you are the current assignee for this package so you can decide.

@TCLamnidis
Copy link
Member

this package has a minotaur archive PR pending, and the provided janno was used there already (and even supplemented).
Getting genotypes from the first authors would be best, but failing that, the information here is already making its way to the PMA

@stschiff stschiff marked this pull request as draft February 3, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants