Skip to content

Conversation

dlvhdr
Copy link
Contributor

@dlvhdr dlvhdr commented Jun 10, 2025

Description

Warning

To be merged on the 22nd of June as part of the migration for filters UI.

What - add the blueprint prop to relevant widgets (see https://github.com/port-labs/Port/pull/7374)
Why -
How -

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

@dlvhdr dlvhdr marked this pull request as ready for review June 10, 2025 13:38
Copy link

github-actions bot commented Jun 10, 2025

TestsPassed ✅SkippedFailedTime ⏱
JUnit Test Report173 ran173 ✅0 ⚠️0 ❌20m 49s 479ms
TestRetriesTime ⏱
JUnit Test Report
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityWithManyRelation111s 180ms

Copy link

Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15560991164/artifacts/3296680519

Code Coverage Total Percentage: 36.4%

Copy link

🚨 The new code coverage percentage is lower than the current one. Current coverage: 71.4
While the new one is: 36.4

Copy link

Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15561135238/artifacts/3296721166

Code Coverage Total Percentage: 55.2%

Copy link

🚨 The new code coverage percentage is lower than the current one. Current coverage: 71.4
While the new one is: 55.2

Copy link

Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15560949926/artifacts/3296965120

Code Coverage Total Percentage: 75.1%

@dlvhdr dlvhdr requested a review from erikzaadi June 10, 2025 14:35
Copy link
Member

@erikzaadi erikzaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the devbox part to the contributing guide please

devbox.json Outdated
},
"shell": {
"init_hook": [],
"scripts": {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could wrap the make scripts here, not sure if relevant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we can do that, but it's not really necessary. make will use the tools installed by devbox.

@@ -18,20 +18,16 @@ description: |-
title = "Microservices"
type = "blueprint-entities"
icon = "Microservice"
blueprint = portblueprint.base_blueprint.identifier
blueprint = portblueprint.baseblueprint.identifier
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pepeConfused, should this be snake cased?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this is generated, I don't know where it's taking it from :S

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's some kind of version change of tfplugindocs, but I can't seem to know which version used to generate these.
I can pin to a version of tfplugindocs in devbox, but it causes a lot of changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok talked to @Tankilevitch annd it's ok. It's in the frontmatter of the file, and https://registry.terraform.io/tools/doc-preview shows it correctly.
The real rendered content is lower in the md file

Copy link

Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15561135238/artifacts/3297675776

Code Coverage Total Percentage: 71.9%

@dlvhdr
Copy link
Contributor Author

dlvhdr commented Jun 10, 2025

Add the devbox part to the contributing guide please

Done

Copy link

Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15564107402/artifacts/3298133308

Code Coverage Total Percentage: 73.8%

Copy link
Member

@erikzaadi erikzaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

@Eyal-Shalev Eyal-Shalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just a documentation change PR?
Why is it marked as breaking change?

Did we do a breaking change to the API on the server?

@dlvhdr
Copy link
Contributor Author

dlvhdr commented Jun 10, 2025

Yes to all

@dlvhdr
Copy link
Contributor Author

dlvhdr commented Jun 11, 2025

Warning

To be merged on the 22nd of June as part of the migration for filters UI.

@dlvhdr dlvhdr force-pushed the dlvhdr/devbox-and-widget-blueprint branch from bcd4189 to 7c07e94 Compare June 11, 2025 08:34
Copy link

Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15580054487/artifacts/3303867076

Code Coverage Total Percentage: 76.2%

Copy link

Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15581499858/artifacts/3304314239

Code Coverage Total Percentage: 75.0%

@dlvhdr dlvhdr changed the title feat: add blueprint to widget example PORT-14153 feat: add blueprint to widget example Jun 18, 2025
Copy link

Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15807039324/artifacts/3377976625

Code Coverage Total Percentage: 72.1%

@dlvhdr dlvhdr merged commit d358c19 into main Jun 22, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants