-
Notifications
You must be signed in to change notification settings - Fork 11
PORT-14153 feat: add blueprint to widget example #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15560991164/artifacts/3296680519Code Coverage Total Percentage:
|
🚨 The new code coverage percentage is lower than the current one. Current coverage: |
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15561135238/artifacts/3296721166Code Coverage Total Percentage:
|
🚨 The new code coverage percentage is lower than the current one. Current coverage: |
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15560949926/artifacts/3296965120Code Coverage Total Percentage:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the devbox part to the contributing guide please
devbox.json
Outdated
}, | ||
"shell": { | ||
"init_hook": [], | ||
"scripts": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could wrap the make scripts here, not sure if relevant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we can do that, but it's not really necessary. make
will use the tools installed by devbox.
@@ -18,20 +18,16 @@ description: |- | |||
title = "Microservices" | |||
type = "blueprint-entities" | |||
icon = "Microservice" | |||
blueprint = portblueprint.base_blueprint.identifier | |||
blueprint = portblueprint.baseblueprint.identifier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pepeConfused, should this be snake cased?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm this is generated, I don't know where it's taking it from :S
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's some kind of version change of tfplugindocs, but I can't seem to know which version used to generate these.
I can pin to a version of tfplugindocs in devbox, but it causes a lot of changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok talked to @Tankilevitch annd it's ok. It's in the frontmatter of the file, and https://registry.terraform.io/tools/doc-preview shows it correctly.
The real rendered content is lower in the md file
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15561135238/artifacts/3297675776Code Coverage Total Percentage:
|
Done |
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15564107402/artifacts/3298133308Code Coverage Total Percentage:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just a documentation change PR?
Why is it marked as breaking change?
Did we do a breaking change to the API on the server?
Yes to all |
Warning To be merged on the 22nd of June as part of the migration for filters UI. |
bcd4189
to
7c07e94
Compare
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15580054487/artifacts/3303867076Code Coverage Total Percentage:
|
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15581499858/artifacts/3304314239Code Coverage Total Percentage:
|
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15807039324/artifacts/3377976625Code Coverage Total Percentage:
|
Description
Warning
To be merged on the 22nd of June as part of the migration for filters UI.
What - add the
blueprint
prop to relevant widgets (see https://github.com/port-labs/Port/pull/7374)Why -
How -
Type of change
Please leave one option from the following and delete the rest: