Add sort to action user inputs #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eyal-Be
force-pushed
the
add-sort-to-action-user-inputs
branch
4 times, most recently
from
77d564e to
f428684
Compare
Eyal-Be
force-pushed
the
add-sort-to-action-user-inputs
branch
from
bf8aecb to
a74e1ee
Compare
erikzaadi
requested changes
Sep 8, 2024
| @@ -2192,3 +2192,73 @@ func TestRequiredApprovalAll(t *testing.T) { | |||
| }, | |||
| }) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
In one of the other tests, please add an assertion that the sort property isn't there
| @@ -88,6 +88,16 @@ resource "port_action" "restart_microservice" { | |||
| default = "https://example.com" | |||
| pattern = "^https://.*" | |||
| } | |||
| service = { | |||
There was a problem hiding this comment.
Could you run terraform fmt on this pretty plz?
There was a problem hiding this comment.
check how it looks locally
| @@ -1111,6 +1153,10 @@ resource "port_action" "create_microservice" { | |||
| }] | |||
| }) | |||
| } | |||
| sort = { | |||
There was a problem hiding this comment.
Is it me or is the indent here a bit askew?
There was a problem hiding this comment.
check how it looks locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - added sort to self service actions user inputs
Why - to enable entities selection sort in the UI
How - added sort to relevant models
Type of change
Please leave one option from the following and delete the rest: