Edited Inactive Tab Color for More Intuitive Selection #1786
+44
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for light active hint colors, edited the text color of inactive tabs to blend in indicating inactivity
|
Hi everyone! Just checking in—has there been any interest or feedback on this PR? Are any adjustments needed? Also, here's what it looks like in another color with transparency: |
|
@andrewtran3643 Hadn't gotten a chance to look at this yet, sorry (our attention's mostly turned towards COSMIC Epoch, which no longer uses Pop!_Shell). I'll take a look at this on behalf of QA tomorrow. I do think it makes sense to derive the inactive tab color from the active hint color so it matches the active tab color. Shouldn't be any problems as long as it works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inactive tab color was hard-coded to
#9B8E8A. When using a dark active hint color, the inactive tab appears lighter than the active tab, which can make it seem like the inactive tab is selected.This PR updates the inactive tab color to use the active hint color, darkened by 20%, and slightly adjusts the text color to be darker for inactive tabs.
This is my first PR—thank you for your patience, and I appreciate any feedback!