[Popover] Match popup styling to designs #1053
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmstick
previously approved these changes
Nov 18, 2025
Contributor
Author
|
Could this potentially be an issue because the greeter wraps its interface in a popover? https://github.com/pop-os/cosmic-greeter/blob/f806087fc89cea8b3c7d78c13536d13cc7c53b57/src/greeter.rs#L976 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this comment in pop-os/cosmic-settings#1567.
I've changed the default Position to Bottom, since Center felt bad IMO, with it covering the button which opened the popup.