feat(sound): redesign with separate device profiles page #1500
Conversation
jacobgkau
left a comment
jacobgkau
left a comment
There was a problem hiding this comment.
First, there's an overflow/sizing issue with the drop-down box on the Device Profiles page. By default, I had no profile selected (not even "Off"), which seems impossible. In that state, most of the drop-down items flowed out of the end of the window:
It seems like longer labels being selected allowed the drop-down to display more of its contents:
Separate issue, but after I selected "Off" as my profile, the device disappeared from the list, making it impossible to turn on again. The point of the "Off" option is to still show the device in the list while it's disabled, so that shouldn't happen.
|
What's the output of 
|
|
Fixed the devices on the device profiles page disappearing when setting their profile to off. Which also fixes the device briefly disappearing when the device's nodes are replaced. |
There was a problem hiding this comment.
On the same machine as yesterday, I still had one of the devices not have any profile visibly selected at first, which shouldn't be possible:
Here is pw-dump from that system: pw-dump-oryp8.txt
If I set the device to "Off", it initially shows itself as "Off", but if I reboot, I end up in the same state as shown above (it boots up set to nothing instead of showing as set to "Off".)
|
I'm still also seeing menu items getting cut off at the edge of the window. Is that a libcosmic bug? Dropdown menus in other COSMIC apps seem to be able to run out the side of the window. |
|
It's a different dropdown widget. I will switch to it |
mmstick
force-pushed
the
sound
branch
2 times, most recently
from
717e099 to
278f24d
Compare
|
The index of the selected profile on that Built-in Audio device should be fixed now |
|
On 8688b54 and oryp8, the profile of If I just boot (defaulting to I know some of this might be audio card weirdness that's outside the scope of COSMIC Settings, but does any of this sound like a COSMIC Settings thing? The two distinct problems are the default/last selected profile not being saved between sessions, and not being able to switch from the default to one of the others successfully without first selecting |
|
From @WatchMkr in Mattermost (posting here so it doesn't get lost)-- the design also calls for the device description to be prepended to the profile name when selecting an input/output device (e.g. |
|
Seems I'll need to add the different routes (ports) to the output/input dropdown lists. Pavucontrol puts those on a separate port dropdown. |
|
Not sure if you were ready for me to look at this again yet, but just to corroborate, on f787c83, I'm seeing the The other problems I mentioned before are still occurring. |
mmstick
force-pushed
the
sound
branch
2 times, most recently
from
cdbd2a9 to
089d65e
Compare
jacobgkau
left a comment
jacobgkau
left a comment
There was a problem hiding this comment.
35e3127 still has reliability issues on oryp8.
If I set Built-in Audio's profile to Analog Stereo Duplex and then reboot, it defaults to Digital Surround 5.1 (IEC958/AC3) Output again.
If I change the profile to Analog Stereo Duplex, then both Output device and Input device show their only option as Built-in Audio, with no route name/description prepended. Changing the speaker volume with hotkeys doesn't work in this state.
If I change the profile to Analog Stereo Output, then Output device changes to Speakers - Built-in Audio, and the speaker hotkeys work. Alternatively, if I open up an app and start playing audio, then the Output device does not change, but the speaker hotkeys do start working.
|
What's the output of Based on the logic that I have, the most likely problem is that the node failed to parse. The node ID is required to set a default sink/source, and the route won't be added to the device name if a node isn't associated with it. |
| .info({ | ||
| let state = Rc::downgrade(&state); | ||
| move |info| { | ||
| if let Some(node) = Node::from_node(info) { |
There was a problem hiding this comment.
This is where the node is parsed. This could be wrapped with dbg!(Node::from_node(info)) to check if all nodes are getting parsed.
jacobgkau
left a comment
jacobgkau
left a comment
There was a problem hiding this comment.
Here is pw-dump after booting on 4a14492, defaulting to S/PDIF: oryp8-4a14492-default-spdif.txt
Here is pw-dump after changing the profile to Analog Stereo Duplex: oryp8-4a14492-duplex.txt
On 4a14492, the speaker hotkeys work immediately after changing the profile to Analog Stereo Duplex, but the Output device is only labeled Built-in Audio, while the Input device is labeled Speakers - Built-in Audio.
|
I think I see the issue |
|
Hoping this fixes the issue you're seeing. |
|
I'm not sure the current solution to devices being plugged/unplugged is working right. I've had a couple of times where when I unplug HDMI, not only does the profile remain selected for the HDMI sound card (which is fine), but the Output device stays on the now-unplugged HDMI port (which is less desired). We probably want the Output device to change to something that's connected. I also had one case on f24d602 where the HDMI device's profile was set to Off after unplugging and remained Off after plugging it in again, like it was before. But not every time. |
|
Carl suggested we just automatically set a device to the first profile in the list when it used to have no profiles available (besides Off and Pro Audio) and a new profile becomes available. It seems like that would solve the usability issue, and ensure the output's at least available to select in the applet after plugging a device in. And would be simpler than trying to remember a history of profiles that were selected before things changed. I am still seeing it often go to Off on unplug (and stay there on re-plug) on f24d602. |
|
The HDMI plug behavior does seem to be behaving slightly better on 34cdc6b, but there are still some issues. For example, after about five plug/unplugs, I saw the profile remain on what it had been automatically set to on plug-in ( |
|
It also seems that the profile being auto-selected when it was set to
|
|
There may not be much we can do about what profile gets selected since we're competing with the pipewire daemon itself. |
|
When testing HDMI plug/unplug on b4ca6d0, the first time I unplugged, the profile went back to Off (as expected with the behavior we're trying for now). The second and third times, it remained on the unplugged profile (which isn't the end of the world, but means the unavailable HDMI output is presented as an output device option and could remain selected). The fourth time, it was set to Off again. @mmstick Just to clarify, is that also something the PipeWire daemon (and/or anything other than COSMIC Settings) is responsible for? I did also just see one case when I plugged in where the profile flickered a whole bunch between the three (stereo, 5.1, and 7.1); it took a couple of seconds for it to settle down and pick the 5.1 to stay on. This spammed the OSD and volume adjustment sound while it was happening. |
|
The daemon is responsible for switching profiles automatically, and that should be influenced based on plugged status and profile priority. But in all my testing it seems to be non-deterministic at times. Perhaps influenced by race conditions as device nodes are recreated. We are attempting to work around the behaviors in cosmic-settings while the page is open, but that does have some limitations. In particular, there's no way to tell if a profile change was intentionally made by the user, or automatically by the daemon. Using the pipewire daemon's socket, we get messages from the daemon about active profile and route changes, but it doesn't indicate whether that was intentional by the user or an automatic selection by the daemon. Currently, we're watching for changes after manually changing device profiles in the interface because the daemon tends to auto-select a random node for a different device during the time it takes for pipewire to recreate device nodes for the newly-selected profile. So for a brief moment a different device will get the default before cosmic-settings can re-select one of the newly-created nodes. Now we have a conditional check for devices that are externally assigned to the Off profile while the page is open. The first profile with an available status will get selected when found. Though it's possible that pipewire may make that choice for us instead of switching to Off. So a patch to pipewire would be more appropriate for tweaking automatic profile behaviors.
Checking. Sounds like a clash with one of our workarounds. |
Closes #1325
Closes #1577
Closes pop-os/cosmic-epoch#655
Closes pop-os/cosmic-epoch#787
Closes pop-os/cosmic-epoch#946
Closes pop-os/cosmic-epoch#1001
Closes pop-os/cosmic-epoch#568
Closes pop-os/cosmic-epoch#1368
wpctl set-profile {{device-id}} {profile-index}}instead ofpactlwpctl set-default {{node-id}}- Enables using wpctl for setting card profiles, default sinks/sources, volume, and mute
- Significant performance and stability improvements
- Wireplumber state no longer gets corrupted