This repository was archived by the owner on May 13, 2020. It is now read-only.
Fix Windows release when using new release process #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `skip_tags` was set to true, we weren't starting a CI job to do a release when a tag like `0.1.0` was pushed. Removing `skip_tags` fixes the "no Windows release" problem encountered during our most recent attempt at releasing. Closes #128
Theodus
approved these changes
Nov 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
skip_tagswas set to true, we weren't starting a CI jobto do a release when a tag like
0.1.0was pushed.Removing
skip_tagsfixes the "no Windows release" problem encounteredduring our most recent attempt at releasing.
Closes #128