This repository was archived by the owner on May 13, 2020. It is now read-only.
Fix broken automated release process #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 large issue: Pushing back to GitHub using the supplied GITHUB_TOKEN does not trigger additonal events. What does this mean? When we push back a release tag like `0.1.0`, the next workflow doesn't trigger. To address, you have to use a personal access token to trigger. This commit makes that change. Additionally, this commit improves error messages from release scripts by having the error messages actually displayed instead of an generic unbound variable error message.
Theodus
approved these changes
Nov 9, 2019
| echo -e "\e[31mA personal access token needs to be set in GITHUB_TOKEN. Exiting." | ||
| if [[ -z "${RELEASE_TOKEN}" ]]; then | ||
| echo -e "\e[31mA personal access token needs to be set in RELEASE_TOKEN." | ||
| echo -e "\e[31mIt should not be secrets.GITHUB_TOKEN. It has to be a" |
There was a problem hiding this comment.
Should this "It should not be secrets.GITHUB_TOKEN." be here?
There was a problem hiding this comment.
The default assumption of someone who knows GH actions would be to use secrets.GITHUB_TOKEN. That is what I was doing. It won't work if you do.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 large issue:
Pushing back to GitHub using the supplied GITHUB_TOKEN does not
trigger additonal events. What does this mean? When we push back a
release tag like
0.1.0, the next workflow doesn't trigger.To address, you have to use a personal access token to trigger.
This commit makes that change.
Additionally, this commit improves error messages from release scripts
by having the error messages actually displayed instead of an generic
unbound variable error message.