This repository was archived by the owner on May 13, 2020. It is now read-only.
"Remove" regex dependency #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex library has been removed from ponyc and now lives in its own library. This causes a bit of a problem for usage with stable. How would we install that library so we can test stable? With the stable we just built? Perhaps. Regex is only used in an integration test and it can probably be accomplished in another fashion. So that we can build stable for now and not break other things that depend on it, I've commented out the small bit of test code that uses regex. I will be opening an issue to come up with a fix.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex library has been removed from ponyc and now lives in its
own library. This causes a bit of a problem for usage with stable.
How would we install that library so we can test stable? With the
stable we just built? Perhaps. Regex is only used in an integration
test and it can probably be accomplished in another fashion.
So that we can build stable for now and not break other things that
depend on it, I've commented out the small bit of test code that
uses regex. I will be opening an issue to come up with a fix.