Add fetch tests #136
Add fetch tests #136
Conversation
- adds `fetch` tests for the following scenarios:
* empty deps
* empty dir
* mutually recursive
* self referential
| test(_TestFetchEmptyDeps) | ||
| test(_TestFetchEmptyFile) | ||
| test(_TestFetchMutuallyRecursive) | ||
| test(_TestFetchSelfReferential) |
There was a problem hiding this comment.
I think you should add a test for transitive dependencies. That would mean renaming the regression-120 stuff to be a more generic "transitive dependencies" test.
| Verify that when using corral.json with empty deps, that there | ||
| are never any sync, tag query, or checkout operations executed. | ||
| """ | ||
|
|
There was a problem hiding this comment.
extra newline here and elsewhere in this file.
|
|
||
| fun val checkout_op(rev: String, next: RepoOperation): RepoOperation => | ||
| _RecordedCheckout(_recorder, next) | ||
|
|
|
|
||
| primitive _TestRepoCache | ||
| fun apply(auth: AmbientAuth, path: String): FilePath ? => | ||
| FilePath(auth, path)? |
| @@ -0,0 +1,101 @@ | |||
| use "files" | |||
There was a problem hiding this comment.
rather than sticking everything in "_test_helpers.pony"
what about a file for the helpers that are only opsrecorder test related?
_test_helpers is very generic and as bad as a "util" package.
so it could be
"_test_data_test_helpers"
"_ops_recorder_test_helpers"
or perhaps better:
_test_helpers_test_data
_test_helpers_ops_recorder
I'm not sure what is best, but I think that we can do better than _test_helpers.
There was a problem hiding this comment.
I'll break this out in a meaningful way
|
A few minor comments left. I think the big one is that there is no test for transitive dependencies being handled correctly, as I noted. |
OpsRecorder, etc) from thecmd/updatetests for usage with othercmdscmd/fetchfor the following scenarios: