Skip to content

Commit

Permalink
Fix bug with default bundle directory handling (#275)
Browse files Browse the repository at this point in the history
There was a bug in corral's handling of the the `-d` command line
option. The default value was set to the string "<cwd>". This would
result in corral.json not being found.

The bug wasn't triggered because a bug in the Pony standard library
prevented the default value from correctly being applied. Once that
bug was fixed, corral stopped working unless a `-d` value was
provided.
  • Loading branch information
SeanTAllen authored Jan 23, 2025
1 parent e0b1ffc commit d049d77
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .release-notes/275.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
## Fix bug with default bundle directory handling

There was a bug in corral's handling of the the `-d` command line option. The default value was set to the string "<cwd>". This would result in corral.json not being found.

The bug wasn't triggered because a bug in the Pony standard library prevented the default value from correctly being applied. Once that bug was fixed, corral stopped working unless a `-d` value was provided.
4 changes: 2 additions & 2 deletions corral/cli.pony
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ primitive CLI
default' = false)
OptionSpec.string(
"bundle_dir",
"The directory where the bundle's corral.json and lock.json are located."
"The directory where the bundle's corral.json and lock.json are located. Defaults to the current working directory."
where short' = 'd',
default' = "<cwd>")
default' = "")
],
[
CommandSpec.leaf(
Expand Down

0 comments on commit d049d77

Please sign in to comment.