bench: serve dist/ ourselves; tachometer's server corrupts wasm - #9
Merged
Conversation
tachometer's static server reads responses as text when its cache is on (always, outside manual mode) and re-encodes them: the 533,697-byte component came out as 644,034 bytes and never instantiated, so every sample timed out. Benchmarks are now remote URLs against an ephemeral Deno file server started by bench/run.ts, which also sidesteps the reserved /bench.js path and the koa-node-resolve rewrite of served JS. The runner also stops timing at commit rather than the next animation frame: the final DOM is identical across variants, so paint is not a differentiator, and rAF is not reliable in tachometer's popup windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first two `bench.yml` runs on main failed with every sample timing out. Two causes, found by replicating tachometer's flow step by step on an x86 runner (this arm64 box cannot run chromedriver):
Fix: `bench/run.ts` serves `dist/` on an ephemeral Deno file server and hands tachometer remote URLs, so tachometer starts no server at all (also sidesteps the koa-node-resolve rewrite of served JS). The in-page runner now stops timing at commit rather than the next animation frame: the final DOM is identical across variants so paint is not a differentiator, and rAF is unreliable in tachometer's `window.open` popups.
Verified on a runner via a temporary diagnostic workflow (removed in the last commit): tachometer produced a result table for `dioxus-bench/native/direct/create-1k`.