driver: host-call arrival follow-ups from the #289 review - #290
Merged
Conversation
- Drop the arrival racer from the settlement pump: every registration its snapshot can miss reaches `ensureSettlementPump` (which fires the nudge) — `driveAsync`'s finally, `drive`'s synchronous completion, and the host-activity pump's async half is itself a `driveStoreAsync`. The rationale comment it carried described a state the nudge already covers. - Name the second no-new-driver registration path in the notes: `HostActivity.pump()`'s synchronous drain while its async half is parked in `driveAsync` — the stream-dom shape the fix was found in. - Race the one-shot at the wedge-detector park too, so "every `driveAsync` park that spreads `pendingHostCalls`" holds without an exception. No behavior change on any reachable path; `just test-runtime` 702 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the post-merge review of #289. No behavior change on any reachable path.
ensureSettlementPump, which fires the existing nudge:driveAsync's finally,drive's synchronous completion, and the host-activity pump's async half is itself adriveStoreAsync. The rationale comment it carried ("a host call registered by a driver that is live right now") described a state the nudge already covers, and any driver live meanwhile is what the pump stands down for. Replaced with a note saying why it does not ride there.HostActivity.pump()'s synchronous drain (exec/host_streams.ts) while its async half is already parked indriveAsyncruns guest code with no depth bump — the stream-dom shape the bug was found in. The header note and both site comments now name it beside the syncdrivepath.parked.length === 0), so the header's claim — raced by everydriveAsyncpark that spreadspendingHostCalls— holds without an exception.Gates:
just check,just test-runtime(702 passed),just version-guard-local.Automerge armed.