ct-runner tests: one FULL_RUN_COUNTS constant; bundle test asserts its own facts - #288
Merged
Conversation
…s own facts Five tests spelled out the identical full RunCounts tally for an unfiltered run of the fixture suite while testing something else (golden output, freshCases=false, shard-absent identity, bundle contents); every additive field meant editing all of them, and the one outside ct-runner broke CI on #287. The four ct-runner sites now share a constant in support.ts. The release-bundle test is about the tags inventory surviving bundling, so it asserts na and total — severing its coupling to the tally's shape. Tests whose subject IS the counts keep explicit literals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #287. Five tests spelled out the identical full
RunCountstally for an unfiltered fixture run while testing something else; every additive field meant editing all of them, and the one outside ct-runner (tools/release-bundle/bundle_test.ts) broke CI on #287.FULL_RUN_COUNTSintests/support.ts.counts.na === 1andcounts.total === 6— the facts it is about — severing its coupling to the tally shape.only, tags) keep their explicit literals, since the exhaustive object is what catches a case landing in the wrong bucket.Net −30 lines.
just test-ct-runner24/0,just test-bundle2/0,deno task checkclean.