cargo: pin wasmtime-environ and wit-parser once, in the workspace table - #274
Merged
Conversation
The two pins must move together (wasmtime 47 links wasmparser 0.252; wit-parser 0.252 is the same wasm-tools release) but lived in two crate manifests joined only by a comment. Both now come from [workspace.dependencies], and `just test-rust` fails if wasmparser, wit-parser or wasm-encoder resolve to more than one version across translator-shim + bindgen (testgen excluded: it uses wast 255 on purpose).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
wasmtime-environ =47.0.3(translator-shim) andwit-parser =0.252.0(bindgen) pins must move together but were joined only by a "bump together" comment in each manifest. Both now come from[workspace.dependencies]in the rootCargo.toml; the crates use{ workspace = true }.just test-rustgains a drift check: fails ifwasmparser,wit-parserorwasm-encoderresolve to more than one version across translator-shim + bindgen. testgen is excluded (useswast255 deliberately, per the architecture.md risk table).Considered and rejected: routing both through the
wasmtimecrate's re-exports (reexport-wasmparser,wit-parser).wasmtime::component::wit_parserrequires theruntimefeature, which on the shim'swasm32-unknown-unknowncdylib needs the custom-platform features plus stubwasmtime_mprotect/munmap/page_size/tls_getsymbols to link, and adds ~19 crates — for an engine the shim never runs.Gates:
cargo build --workspace, wasm32 release build of the shim,just test-rust,just version-guard-local— all pass.Cargo.lockunchanged. Automerge armed.