translator-shim: drop redundant wasmparser dep - #273
Merged
Merged
Conversation
…s re-export Removes the separate wasmparser=0.252.0 dependency that had to be manually kept in sync with wasmtime-environ's own pinned wasmparser version; wasmtime_environ already re-exports it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the separate
wasmparser = "0.252.0"dependency incrates/translator-shim/Cargo.toml, which had to be manually kept in sync with the version wasmtime-environ links against.wasmtime_environalready re-exportswasmparser, solib.rsnow imports it from there instead.Verified:
cargo build -p translator-shimis clean; no remaining directwasmparser::imports outside the re-export;Cargo.lockshrinks by the now-unused duplicate entry.