Fix deprecation warnings #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
when is this fix planned to be released? Would be nice to have the warnings fixed soon :) |
rmburg
reviewed
Nov 12, 2024
| }) | ||
| } | ||
| context { | ||
| repetitions.update(rep => calc.max(rep, pause-counter.get().first() + 1)) |
There was a problem hiding this comment.
Calling .get() in this closure does not work, since the context is not available in it.
Alternative:
let pauses = pause-counter.get().first() + 1
repetitions.update(rep => calc.max(rep, pauses))
|
Still getting these warnings. Any chance for a (minor) release for this? The last release is ages ago |
|
You're in luck. I'm currently heavily working on getting a new release ready. Sorry I made you wait for so long! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses deprecation warnings in typst 0.12-0-rc1. It fixes issue #180.