Skip to content

Create extension for Model\Languages::get_list() #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 18, 2025
Merged

Create extension for Model\Languages::get_list() #14

merged 4 commits into from
Jul 18, 2025

Conversation

Screenfeed
Copy link
Contributor

Closes #13.

Use the same extension than the one for PLL_Model::get_languages_list().

@Screenfeed Screenfeed self-assigned this Jul 11, 2025
@Screenfeed Screenfeed added the enhancement New feature or request label Jul 11, 2025
Hug0-Drelon
Hug0-Drelon requested changes Jul 15, 2025
View reviewed changes
@Screenfeed Screenfeed requested a review from Hug0-Drelon July 15, 2025 08:19
Hug0-Drelon
Hug0-Drelon requested changes Jul 15, 2025
View reviewed changes
Copy link
Member

@Hug0-Drelon Hug0-Drelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should extension.neon be updated as well?

@Screenfeed
Copy link
Contributor Author

Should extension.neon be updated as well?

Monkey Puppet

I also removed the PLL prefix from the class name, since it has nothing to do with PLL_Model.

@Screenfeed Screenfeed requested a review from Hug0-Drelon July 15, 2025 09:03
@Chouby Chouby merged commit 5162dd4 into master Jul 18, 2025
@Chouby Chouby deleted the model-languages-list-extension branch July 18, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hug0-Drelon Hug0-Drelon Hug0-Drelon approved these changes

Assignees

@Screenfeed Screenfeed

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create extension for Model\Languages::get_list()
3 participants
@Screenfeed @Hug0-Drelon @Chouby