PersistentVector, transients, polishing #7
Conversation
…ve option references
…transientMap Conflicts: lib/src/map_impl.dart
Transient map
Conflicts: lib/src/vector.dart
Conflicts (deleted): benchmark/map_bench_wordcount.dart benchmark/src/benchmark.dart benchmark/src/simple_map_1.dart benchmark/src/simple_map_2.dart
Conflicts: lib/src/map_impl.dart
|
@tomaskulich ping |
|
sorry guys, wasn't following this discussion for some time. @polux : I'll ask the contributors to sign the CLA; I'll let you know, when this happens. Also, I created new PR with the newest changes; you can close this one. |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
@tomaskulich, awesome! Thanks! |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
tomaskulich
force-pushed
the
master
branch
3 times, most recently
from
391facb to
1447048
Compare
Not sure, if you want to merge this.. we did several modifications to the codebase, which you may not like