Skip to content
This repository was archived by the owner on Aug 27, 2024. It is now read-only.

Update index.md #768

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Conversation

wheresaddie
Copy link
Contributor

minor edits

@wheresaddie wheresaddie requested a review from apopiak November 3, 2020 14:05
Copy link
Contributor

@apopiak apopiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apopiak apopiak merged commit b8ba3bb into apopiak-runtime-migration Nov 3, 2020
@apopiak apopiak deleted the wheresaddie-patch-minor branch November 3, 2020 15:27
@apopiak
Copy link
Contributor

apopiak commented Nov 3, 2020

This index.md was adjusted from the forkless runtime upgrade tutorial, so we might want to apply some of your suggestions to it as well.

@danforbes
Copy link
Contributor

@apopiak can you be more specific about the changes that you think should be applied to the the tutorial? I have opened a PR #772 that reverts many of the changes in this one but I'm happy to hear dissenting opinions. My apologies for missing this PR and some of the other related ones. @athei please feel free to comment on #772 as well - I would like to try our best to come to some type of consensus on this issue.

Copy link
Contributor

@apopiak apopiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danforbes These are the places where Addie made suggestions that would also apply to the other tutorial.

@@ -1,18 +1,18 @@
---
title: Introduction
Introduction
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different from the other tutorial

Comment on lines -5 to +7
One of the defining features of the Substrate blockchain development framework is its support for
One of the defining features of the Substrate blockchain development framework is the support for
**forkless runtime upgrades**. Forkless upgrades are a means of enhancing a blockchain runtime in a
way that is supported and protected by the capabilities of the blockchain itself. A blockchain's
way that supports and protects the capabilities of the blockchain itself. A blockchain's
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different from the other tutorial

This tutorial will use the Substrate Developer Hub
This tutorial will use the Substrate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different from the other tutorial

Comment on lines -36 to +37
If you're an experienced developer and wish to skip those
tutorials, you can clone the
If you're a more experienced developer and wish to skip those
tutorials, you can clone the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different from the other tutorial

apopiak pushed a commit that referenced this pull request Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants