-
Notifications
You must be signed in to change notification settings - Fork 60
[FIX] - Zero to hero tutorials #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures the Zero-to-Hero tutorials render correctly by pinning benchmark tooling, realigning code snippet references, and fixing navigation order.
- Pin
frame-omni-bencher
to version 0.10.0 - Update code snippet link ranges and highlight lines across tutorial markdowns
- Remove a mis-indented duplicate entry in the tutorial navigation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
pallet-unit-testing.md | Adjusted snippet link line numbers by –1 |
pallet-benchmarking.md | Pinned bencher version; updated highlight line ranges |
build-custom-pallet.md | Realigned snippet link ranges in examples |
add-pallets-to-runtime.md | Updated snippet ranges; clarified build command context |
.pages | Removed mis-indented duplicate navigation entry |
Comments suppressed due to low confidence (1)
tutorials/polkadot-sdk/parachains/zero-to-hero/pallet-benchmarking.md:27
- Consider adding a reminder before step 1 that the pallet must be added to the runtime and the runtime recompiled first, e.g.: “Ensure you’ve added your pallet to the runtime and run
cargo build
before benchmarking to prevent breakage.”
1. Install the [`frame-omni-bencher`](https://crates.io/crates/frame-omni-bencher){target=\_blank} command-line tool:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
🔍 Documentation URL Checker This PR modifies documentation files in ways that could potentially create broken links. Deleted files:
🚨 Please review these changes carefully 🚨 If not handled properly, broken links (404 errors) could appear. To maintain a smooth user experience, consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked and everything seems good to go.
This PR fixes the zero to hero:
error[E0432]: unresolved import sc_network_types::kad
This is needed to work on #689