fix: Fix glob expansion matching extra files #21991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21736
We do globs by converting first converting to regex (I assume to avoid a dependency). This PR rewrites the conversion and fixes the wildcard
**
glob accidentally matching extra files.Previously we would convert
**
to.*
in regex, but this would cause e.g.a/**/b
to matcha/<dir>/xb
. It is now instead translated to(.*/)?
to ensure the matching is halted at the last forward-slash.