Also fuzz test the JSONB code #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this we only fuzz tested the code on normal table columns. But with the code for the normal columns and jsonb fields getting some differences it's good to test both.
erikdubbelboer
force-pushed
the
fuzz-jsonb
branch
from
efd6120 to
9eb6a19
Compare
Closed
koenbollen
approved these changes
Jun 8, 2024
| conditions, _, err := c.Convert([]byte(in), 1) | ||
| if err == nil && conditions != "" { | ||
| j, err := pg_query.ParseToJSON("SELECT * FROM test WHERE 1 AND " + conditions) | ||
| if err != nil { | ||
| t.Fatalf("%q %q %v", in, conditions, err) | ||
| } | ||
|
|
||
| t.Log(j) |
There was a problem hiding this comment.
Did you mean to keep this log statement in?
There was a problem hiding this comment.
Yes, it's very useful to see the generated AST when an input fails. It doesn't print anything for the cases that don't fail.
There was a problem hiding this comment.
I was wondering if it would output with -v, but it does not. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this we only fuzz tested the code on normal table columns. But with the code for the normal columns and jsonb fields getting some differences it's good to test both.