Access Control Options 🔒 #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this library has been insecure by default, this change will make one of the new access control options required.
koenbollen
commented
Oct 11, 2024
erikdubbelboer
requested changes
Oct 16, 2024
erikdubbelboer
previously approved these changes
Oct 18, 2024
erikdubbelboer
approved these changes
Oct 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding access control options, making the converter error if a disallowed column/field is queried.
Previously this library has been insecure by default, users could easily make the mistake of opening up their entire database. This change makes it required to supply at least one access control option.
New options:
filter.WithAllowAllColumns()Allow filtering of all columns, same as the previous behaviour
filter.WithAllowColumns(...)Allow only selected columns
filter.WithDisallowColumns(...)Disallow certain columns, used in combination with WithAllowAllColumns() and WithNestedJSONB().
Note: This change is not backwards compatible!⚠️