Implement $exists #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdubbelboer
force-pushed
the
more-test-data
branch
from
bbadf91 to
a827073
Compare
Closed
koenbollen
reviewed
Jun 8, 2024
Comment on lines
+155
to
+185
| isNestedColumn := c.nestedColumn != "" | ||
| for _, exemption := range c.nestedExemptions { | ||
| if exemption == key { | ||
| isNestedColumn = false | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
This code is duplicated in the case nil: as well, we could lift it above the switch.
There was a problem hiding this comment.
Yeah we can change those once the two pulls are both merged.
| } | ||
| if !isNestedColumn { | ||
| // There is no way in Postgres to check if a column exists on a table. | ||
| return "", nil, fmt.Errorf("$exists operator not supported on non-nested jsonb columns") |
There was a problem hiding this comment.
Alternatively we can always return TRUE if it's not a nested column (or this could be an option).
There was a problem hiding this comment.
But that's not true. The column can also not exist. The only way to actually check is selecting from information_schema.columns which seems dangerous and not possible since we don't know the table name.
There was a problem hiding this comment.
That's right, good point. 👍
koenbollen
previously approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://www.mongodb.com/docs/manual/reference/operator/query/exists/