Add more error handling #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle undefined entityType
|
This was also required in my node application to stop it from crashing under certain data conditions |
|
In what conditions the entityType is not found? Seems to me it should be always found for the collection so we should rather find the reason why it is not found rather than silently ignore this. |
|
I'm dynamically creating entityTypes from an elasticsearch query (using get mappings API). Sometimes the mapping for a dataset does not exist. Therefore, an entityType will not exist for a EntitySet in my case. With this and #11 and #13, the API will still function (i.e return data) and not crash the node process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle undefined entityType