Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: initial empty scaffold project #69

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Oct 24, 2024

init step for podman-desktop/podman-desktop#8972

you'll get an empty screen

Change-Id: Ie39624fa2bb98774a44cdfab0897327cd7b1b63e

@benoitf benoitf requested a review from a team as a code owner October 24, 2024 08:19
@benoitf benoitf requested review from cdrage, deboer-tim and SoniaSandler and removed request for a team October 24, 2024 08:19
init step for podman-desktop/podman-desktop#8972

Change-Id: Ie39624fa2bb98774a44cdfab0897327cd7b1b63e

Signed-off-by: Florent Benoit <[email protected]>
Change-Id: Ic9673b19f3db38e668659f5f68e5425753c16f23
@benoitf
Copy link
Contributor Author

benoitf commented Oct 24, 2024

ready for review, checks are ✅

since the initial PR, new components are there

Change-Id: I67f853a042f597cec55866d85dda00df3973c3fb
Signed-off-by: Florent Benoit <[email protected]>
Change-Id: I598d755cd59b985ca1868cebb0ad1067e09e6cdd
Signed-off-by: Florent Benoit <[email protected]>
eslint.config.mjs Outdated Show resolved Hide resolved
@@ -0,0 +1,483 @@
@scope (.light) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker, jsut a remark: I am wondering if we should not publish this somewhere, as we will always need to update it to keep it updated :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's my intent 👍

Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Change-Id: I5b26bfc3f873e1d05b13b603dce806503a3eecd5
Signed-off-by: Florent Benoit <[email protected]>
@benoitf benoitf requested a review from jeffmaury October 24, 2024 09:26
Copy link
Contributor

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM here too for first interation, let's test this out

@cdrage cdrage merged commit 2588b04 into podman-desktop:main Oct 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants