Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add podman-quadlet 0.7.0 #231

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

axel7083
Copy link
Contributor

Adding the version 0.6.0 of the Podman Quadlet extension I made during the devweek!

Repository https://github.com/axel7083/pd-extension-quadlet

@axel7083 axel7083 requested review from benoitf and a team as code owners January 10, 2025 13:56
@axel7083 axel7083 requested review from cdrage and gastoner and removed request for a team January 10, 2025 13:56
@axel7083 axel7083 force-pushed the chore/add-podman-quadlet-0-6-0 branch from 602bfa8 to 1ff8a75 Compare January 10, 2025 13:57
@cdrage
Copy link
Contributor

cdrage commented Jan 10, 2025

Should we move the extension to under podman-desktop org before adding it here?

@axel7083
Copy link
Contributor Author

Should we move the extension to under podman-desktop org before adding it here?

For now I will be keeping it under my profils, and later we can move it under the podman-desktop organisation if other members want to join the development!

Copy link
Contributor

@gastoner gastoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: display name of the publisher is invalid, it's a nickname

@axel7083 axel7083 requested a review from benoitf January 13, 2025 16:41
@axel7083
Copy link
Contributor Author

axel7083 commented Jan 15, 2025

cc @benoitf I updated the displayName field

@benoitf
Copy link
Contributor

benoitf commented Jan 15, 2025

yes I saw that but AFAIK @jeffmaury wanted to move it to another repository first

Signed-off-by: axel7083 <[email protected]>
@axel7083 axel7083 changed the title chore: add podman-quadlet 0.6.0 chore: add podman-quadlet 0.7.0 Jan 16, 2025
@axel7083 axel7083 merged commit 1b0fd65 into podman-desktop:main Jan 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants