chore: add disclaimer that to test VM, have to add ssh key #1685
+50
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
requested review from
benoitf,
feloy and
SoniaSandler
and removed request for
a team
cdrage
commented
May 28, 2025
| <!-- If on Linux, warn that during the build, credentials will be asked in order to run an escalated privileged build prompt --> | ||
| {#if isLinux} | ||
| <p class="text-sm text-[var(--pd-content-text)] pt-1"> | ||
| <p class="text-sm text-[var(--pd-content-text)] m-0 pt-0"> |
There was a problem hiding this comment.
FYI, I changed the margin as well as the padding so it looks nicer. The default (from text-sm) was adding too much spacing.
cdrage
changed the title
deboer-tim
reviewed
May 29, 2025
packages/frontend/src/Build.spec.ts
Outdated
|
|
||
|
|
||
| // The below mocks are the same across all tests. | ||
| const setupPlatformMocks = (isMac: boolean, isWindows: boolean, isLinux: boolean) => { |
There was a problem hiding this comment.
Suggestion: const setupPlatformMocks = (platform: string) => {
and
vi.mocked(bootcClient.isMac).mockResolvedValue(platform == 'macOS'); ...
and
{ platform: 'macOS', shouldShow: true }, ...
seems simpler?
### What does this PR do? * Adds a small disclaimer that only appears on mac or linux that you should add your SSH key + do output as raw or qcow2 * For this PR, I also did an alternative way of doing tests since I did not want to copy / paste and only be changing one thing. So in this PR the tests are "table-based". ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes podman-desktop#1569 ### How to test this PR? <!-- Please explain steps to reproduce --> 1. pnpm watch 2. See that the disclaimer is shwon on the build page. Signed-off-by: Charlie Drage <[email protected]>
|
Fixed and changes incorporated regarding the test as well as placement of the disclaimer!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: add disclaimer that to test, have to add ssh key
What does this PR do?
should add your SSH key + do output as raw or qcow2
not want to copy / paste and only be changing one thing. So in this PR
the tests are "table-based".
Screenshot / video of UI
What issues does this PR fix or reference?
Closes #1569
How to test this PR?
Signed-off-by: Charlie Drage [email protected]