chore: fix backend code coverage report #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deboer-tim
requested review from
benoitf,
dgolovin and
SoniaSandler
and removed request for
a team
benoitf
reviewed
Feb 11, 2025
packages/backend/vite.config.js
Outdated
| output: { | ||
| entryFileNames: '[name].js', | ||
| entryFileNames: '[name].cjs', |
There was a problem hiding this comment.
question: I don't know how it can work in your app if you change the extension suffix but not changing the path in package.json ?
There was a problem hiding this comment.
Replaced commit with one to only add the missing extension.
| @@ -27,9 +27,10 @@ const config = { | |||
| coverage: { | |||
| provider: 'v8', | |||
| reporter: ['lcov', 'text'], | |||
| extension: '.ts', | |||
There was a problem hiding this comment.
AFAIK it seems this is the fix, so I would rather split into chunks
some are code formatting, this one is a fix and the previous one is a change but usually it's b/c the type is changed to module
There was a problem hiding this comment.
Done, commit only fixes vitest.config now.
Code coverage reports were including lots of files that aren't in the package. As usual, my first step was to steal from the AI Lab extension! :) The fix is in vitest.config. Fixes podman-desktop#1321. Signed-off-by: Tim deBoer <[email protected]>
benoitf
approved these changes
Feb 12, 2025
axel7083
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Code coverage reports were including lots of files that aren't in the package.
As usual, my first step was to steal from the AI Lab extension! :) The fix is in vitest.config, but I also found some minor differences/formatting in vite.config that I thought were worth picking up and aligning to.
Screenshot / video of UI
Coverage report down from multiple pages to:
What issues does this PR fix or reference?
Fixes #1321.
How to test this PR?
pnpm test:backend