Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing delete action #1317

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

deboer-tim
Copy link
Contributor

What does this PR do?

The disk image details page didn't have any actions, which is different from every other details page. This adds actions, but only Delete since the other actions are essentially just links to tabs here.

Screenshot / video of UI

Screenshot 2025-02-11 at 9 01 13 AM

What issues does this PR fix or reference?

Fixes #1299.

How to test this PR?

Delete a disk image from within the details page.

The disk image details page didn't have any actions, which is different from
every other details page. This adds actions, but only Delete since the other
actions are essentially just links to tabs here.

Fixes podman-desktop#1299.

Signed-off-by: Tim deBoer <[email protected]>
@deboer-tim deboer-tim requested a review from a team as a code owner February 11, 2025 14:01
@deboer-tim deboer-tim requested review from dgolovin, jeffmaury and gastoner and removed request for a team February 11, 2025 14:01
Copy link

@gastoner gastoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay it's back! LGTM! :)

@cdrage cdrage merged commit 904b25a into podman-desktop:main Feb 11, 2025
6 checks passed
@deboer-tim deboer-tim deleted the disk-image-delete branch February 11, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nit: no actions in disk image details
4 participants