chore: missing rpc init #1306
Merged
chore: missing rpc init #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the multi-channel RPC in podman-desktop#1300 we switched from automatic init via constructor to requiring init() to be called explicitly, I just missed committing this one critical line. Fixes podman-desktop#1301. Signed-off-by: Tim deBoer <[email protected]>
deboer-tim
requested review from
benoitf,
dgolovin,
SoniaSandler and
cdrage
and removed request for
a team
benoitf
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With the multi-channel RPC in #1300 we switched from automatic init via constructor to requiring init() to be called explicitly, I just missed committing this one critical line.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Fixes #1301.
How to test this PR?
See issue, just check examples or builds page appears.