chore: update vite, vitest and @sveltejs/vite-plugin-svelte #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
force-pushed
the
update-vite-all
branch
from
84cd824 to
f0e53a9
Compare
benoitf
requested review from
dgolovin,
feloy,
axel7083,
cdrage and
deboer-tim
and removed request for
a team
deboer-tim
approved these changes
Feb 6, 2025
deboer-tim
requested changes
Feb 6, 2025
There was a problem hiding this comment.
The build looked fine, but when I tried to run this branch the extension doesn't load at all. This is what's in the extension console log:
Uncaught Svelte error: lifecycle_function_unavailable
`mount(...)` is not available on the server
https://svelte.dev/e/lifecycle_function_unavailable
at hh (http://f5e6f914-4457-48f4-b580-11e4f97cd4f0.webview.localhost:44000/media/index-BWVFyiS1.js:23:11416)
at uh (http://f5e6f914-4457-48f4-b580-11e4f97cd4f0.webview.localhost:44000/media/index-BWVFyiS1.js:25:147)
at http://f5e6f914-4457-48f4-b580-11e4f97cd4f0.webview.localhost:44000/media/index-BWVFyiS1.js:91:894
at http://f5e6f914-4457-48f4-b580-11e4f97cd4f0.webview.localhost:44000/media/index-BWVFyiS1.js:1:173
at http://f5e6f914-4457-48f4-b580-11e4f97cd4f0.webview.localhost:44000/media/index-BWVFyiS1.js:91:916
|
what the e2e tests do then ? |
benoitf
force-pushed
the
update-vite-all
branch
from
f0e53a9 to
22af752
Compare
|
@deboer-tim I downgraded vite, on my end it's ok |
fixes dependabot issues Signed-off-by: Florent Benoit <[email protected]>
benoitf
force-pushed
the
update-vite-all
branch
from
22af752 to
d340540
Compare
|
rebased to fix conflicts |
deboer-tim
approved these changes
Feb 6, 2025
|
FYI upgrading to vite 6 MAYYY (haven't 100% confirmed yet) have messed up how we show svelte code, that's why I had to revert it before: #1116 See new issues: Pointing towards our svelte code not being up-to-date, so most likely fix it svelte side rather than reverting back to 5 again. |
|
I think reactivity should not be related to the updated components directly maybe there is a problem in the component, just that it's being highlighted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
update vite, vitest and @sveltejs/vite-plugin-svelte
try to update as vitest 3 has default with vite 6, and @sveltejs/vite-plugin-svelte requires new vite 6
so need to update 3 of them at once
Screenshot / video of UI
What issues does this PR fix or reference?
How to test this PR?
please test carefully