Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rpc message proxy and dispose correctly #1264

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

deboer-tim
Copy link
Contributor

What does this PR do?

The RPC message proxy should be disposed on shutdown. This change just disposes it properly, and drops the timeout down to 5s (aligns with AI Lab change, may also help with a timeout during shutdown).

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

Possibly the cause of podman-desktop/podman-desktop#10926.

Fixes #1263.

How to test this PR?

Try to reproduce podman-desktop/podman-desktop#10926.

The RPC message proxy should be disposed on shutdown. This change just disposes
it properly, and drops the timeout down to 5s (aligns with AI Lab change, may
also help with a timeout during shutdown).

Possibly the cause of
podman-desktop/podman-desktop#10926.

Fixes podman-desktop#1263.

Signed-off-by: Tim deBoer <[email protected]>
@deboer-tim deboer-tim requested a review from a team as a code owner February 3, 2025 15:47
@deboer-tim deboer-tim requested review from benoitf, cdrage and feloy and removed request for a team February 3, 2025 15:47
if (!specialChannels.includes(channel)) {
setTimeout(() => {
const { reject } = this.promises.get(requestId) ?? {};
if (!reject) return;
reject(new Error('Timeout'));
this.promises.delete(requestId);
}, 10000); // 10 seconds
}, 5000); // 5 seconds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}, 5000); // 5 seconds
}, 5_000); // 5 seconds

nit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one more feature in the AI Lab message proxy (multi-channel support) that isn't here. I plan to update to that in #1265 and will do this there.

@deboer-tim deboer-tim merged commit b2e1269 into podman-desktop:main Feb 3, 2025
6 checks passed
@deboer-tim deboer-tim deleted the dispose-rpc branch February 3, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dispose of message proxy
2 participants