Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update setting nav test to match 1.16 #1249

Merged

Conversation

deboer-tim
Copy link
Contributor

What does this PR do?

Tests are checking that when you're at each route, the corresponding nav item (and only that) is selected in the navigation. SettingsNavItem added an extra div in the hierarchy so test s checking the wrong div.

Ideally SettingsNavItem would have aria labels, and the test would look at more of the hierarchy - but it was only a minute to find the problem, fix the test, and add the missing test for examples. If it happens again we can do something better but for now just update the test (and add the missing paths).

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

Fixes #1235.

How to test this PR?

PR test passes.

@deboer-tim deboer-tim requested a review from a team as a code owner January 29, 2025 21:21
@deboer-tim deboer-tim requested review from benoitf, feloy and gastoner and removed request for a team January 29, 2025 21:22
Copy link

@gastoner gastoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM
just fix the linter check

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/podman-desktop/ui-svelte-1.16.0 branch 3 times, most recently from 1596ab5 to 8d90bf8 Compare January 31, 2025 06:37
Fixes #1235.

Signed-off-by: Tim deBoer <[email protected]>
@benoitf benoitf merged commit 8ff09f6 into dependabot/npm_and_yarn/podman-desktop/ui-svelte-1.16.0 Jan 31, 2025
6 checks passed
@benoitf benoitf deleted the settings-nav branch January 31, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants