Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to tailwindcss v4 #1238

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Jan 28, 2025

What does this PR do?

Update to tailwindcss v4

note:

Screenshot / video of UI

What issues does this PR fix or reference?

related to podman-desktop/podman-desktop#10795

How to test this PR?

please carefully review all the screen !!!

@benoitf benoitf requested a review from a team as a code owner January 28, 2025 20:47
@benoitf benoitf requested review from dgolovin, cdrage and axel7083 and removed request for a team January 28, 2025 20:47
@axel7083
Copy link
Contributor

pnpm-lock.yaml is conflicting

@benoitf
Copy link
Contributor Author

benoitf commented Jan 29, 2025

pnpm-lock.yaml is conflicting

yes but it's like egg and chicken problem. If I rebase but nobody test it I'll do rebase all the time while fixing the lock is only a small task.

Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Florent Benoit <[email protected]>
@benoitf
Copy link
Contributor Author

benoitf commented Jan 30, 2025

rebased (and now it included v4.0.1 as a new version is out)

@benoitf benoitf merged commit 038ab6c into podman-desktop:main Jan 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants