chore: add vars for prose markdown generation #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What does this PR do? * Adds "prose" variable definitions in tailwind configuration for markdown rendering. Without this, the rendered markdown does not work in dark mode. * See: containers/podman-desktop-extension-ai-lab#1340 regarding a similar issue ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes podman-desktop#1122 ### How to test this PR? View example details in both dark and light mode <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <[email protected]>
cdrage
requested review from
benoitf,
dgolovin and
axel7083
and removed request for
a team
axel7083
approved these changes
Jan 23, 2025
benoitf
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: add vars for prose markdown generation
What does this PR do?
markdown rendering. Without this, the rendered markdown does not work
in dark mode.
chore(tailwindcss): uses podman desktop var for markdown containers/podman-desktop-extension-ai-lab#1340
regarding a similar issue
Screenshot / video of UI
Screen.Recording.2025-01-23.at.11.40.31.AM.mov
What issues does this PR fix or reference?
Closes #1122
How to test this PR?
No test files needed.
View example details in both dark and light mode.
Signed-off-by: Charlie Drage [email protected]