feat: add support for Google Cloud Engine image type #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the image builder to a recent image, which includes support for the Google Cloud Engine (gce) image type. Adds standard support for this image type to all the standard places in API/backend/frontend/tests. Using a single PR given how minimal and obvious the changes are in each part. Fixes podman-desktop#1175. Signed-off-by: Tim deBoer <[email protected]>
deboer-tim
requested review from
benoitf,
cdrage and
gastoner
and removed request for
a team
cdrage
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the image builder to a recent image, which includes support for the Google Cloud Engine (gce) image type.
Adds standard support for this image type to all the standard places in API/backend/frontend/tests. Using a single PR given how minimal and obvious the changes are in each part.
Screenshot / video of UI
What issues does this PR fix or reference?
Fixes #1175.
How to test this PR?
Tests added. Select GCE and build successfully!