Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backend code coverage reports #1321

Closed
deboer-tim opened this issue Feb 11, 2025 · 0 comments · Fixed by #1322
Closed

Fix backend code coverage reports #1321

deboer-tim opened this issue Feb 11, 2025 · 0 comments · Fixed by #1322
Assignees
@deboer-tim
Labels
kind/enhancement ✨ Issue for requesting an improvement sprint/unplanned

Comments

@deboer-tim
Copy link
Contributor

Is your enhancement related to a problem? Please describe

I noticed code coverage reports for the backend are extremely verbose (several pages long) and include lots of files that aren't actually in the package:

 % Coverage report from v8
---------------------------------------------------------------|---------|----------|---------|---------|------------------------------------------
File                                                           | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                        
---------------------------------------------------------------|---------|----------|---------|---------|------------------------------------------
All files                                                      |    97.6 |    76.53 |   46.72 |    97.6 |                                          
 node_modules/@fortawesome/free-regular-svg-icons              |     100 |      100 |     100 |     100 |                                          
  index.mjs                                                    |     100 |      100 |     100 |     100 |                                          
 node_modules/@fortawesome/free-solid-svg-icons                |     100 |      100 |     100 |     100 |                                          
  index.mjs                                                    |     100 |      100 |     100 |     100 |                                          
 node_modules/@podman-desktop/ui-svelte/dist/alert             |     100 |      100 |     100 |     100 |                                          
  ErrorMessage.svelte                                          |     100 |      100 |     100 |     100 |                                          
 node_modules/@podman-desktop/ui-svelte/dist/button            |     100 |      100 |     100 |     100 |                                          
  Button.svelte                                                |     100 |      100 |     100 |     100 |                                          
  CloseButton.svelte                                           |     100 |      100 |     100 |     100 |                                          
 node_modules/@podman-desktop/ui-svelte/dist/checkbox          |     100 |      100 |     100 |     100 |                                          
  Checkbox.svelte                                              |     100 |      100 |     100 |     100 |                                          
 node_modules/@podman-desktop/ui-svelte/dist/dropdown          |     100 |      100 |     100 |     100 |                                          
  Dropdown.svelte                                              |     100 |      100 |     100 |     100 |                                          
 node_modules/@podman-desktop/ui-svelte/dist/dropdownMenu      |     100 |      100 |     100 |     100 |                                          
  DropDownMenuItem.svelte                                      |     100 |      100 |     100 |     100 |                                          
  DropDownMenuItems.svelte                                     |     100 |      100 |     100 |     100 |                                          
  DropdownMenu.svelte                                          |     100 |      100 |     100 |     100 |                                          
  index.js                                                     |     100 |      100 |     100 |     100 |                                          
 node_modules/@podman-desktop/ui-svelte/dist/icons             |     100 |      100 |     100 |     100 |                                          
  StarIcon.svelte                                              |     100 |      100 |     100 |     100 |                                          
 node...

Describe the solution you'd like

Output coverage report only on files from the package.

Describe alternatives you've considered

No response

Additional context

No response
@deboer-tim deboer-tim added kind/enhancement ✨ Issue for requesting an improvement sprint/unplanned labels Feb 11, 2025
@deboer-tim deboer-tim self-assigned this Feb 11, 2025
deboer-tim added a commit to deboer-tim/podman-desktop-extension-bootc that referenced this issue Feb 11, 2025
@deboer-tim
chore: fix backend code coverage report
f3ff9d3 
Code coverage reports were including lots of files that aren't in the package.

As usual, my first step was to steal from the AI Lab extension! :) The fix is in
vitest.config, but I also found some minor differences/formatting in vite.config
that I thought were worth picking up and aligning to.

Fixes podman-desktop#1321.

Signed-off-by: Tim deBoer <[email protected]>
@deboer-tim deboer-tim mentioned this issue Feb 11, 2025
Merged
deboer-tim added a commit to deboer-tim/podman-desktop-extension-bootc that referenced this issue Feb 11, 2025
@deboer-tim
chore: fix backend code coverage report
e2ab98f 
Code coverage reports were including lots of files that aren't in the package.

As usual, my first step was to steal from the AI Lab extension! :) The fix is in
vitest.config.

Fixes podman-desktop#1321.

Signed-off-by: Tim deBoer <[email protected]>
deboer-tim added a commit to deboer-tim/podman-desktop-extension-bootc that referenced this issue Feb 11, 2025
@deboer-tim
chore: fix backend code coverage report
0729da7 
Code coverage reports were including lots of files that aren't in the package.

As usual, my first step was to steal from the AI Lab extension! :) The fix is in
vitest.config.

Fixes podman-desktop#1321.

Signed-off-by: Tim deBoer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deboer-tim deboer-tim

Labels
kind/enhancement ✨ Issue for requesting an improvement sprint/unplanned
Projects
Podman Desktop Planning
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix backend code coverage report deboer-tim/podman-desktop-extension-bootc
1 participant
@deboer-tim