Virtual Machine tab no longer refreshing #1304
Assignees
Labels
kind/bug 🐞
Something isn't working
Comments
deboer-tim
added a commit
to deboer-tim/podman-desktop-extension-bootc
that referenced
this issue
Feb 10, 2025
Moving to svelte 5, state objects are proxied. Normally that's an implementation detail, but when you try to pass the proxies through rpc they can't be cloned and result in errors. We could use $state.snapshot(build) every time we pass objects from the UI to the API, but we really shouldn't be passing whole objects to the backend and blindly trusting that the objects (including all properties) match what the backend knows anyway. This changes the three affected API functions to accept ids instead of objects, and the backend looks up the objects before acting. Although it's slightly more work on the backend, this is a better/more robust API, and also avoids the svelte 5 proxy issue. Fixes podman-desktop#1304. Signed-off-by: Tim deBoer <[email protected]>
deboer-tim
added a commit
to deboer-tim/podman-desktop-extension-bootc
that referenced
this issue
Feb 10, 2025
Moving to svelte 5, state objects are proxied. Normally that's an implementation detail, but when you try to pass the proxies through rpc they can't be cloned and result in errors. We could use $state.snapshot(build) every time we pass objects from the UI to the API, but we really shouldn't be passing whole objects to the backend and blindly trusting that the objects (including all properties) match what the backend knows anyway. This changes the three affected API functions to accept ids instead of objects, and the backend looks up the objects before acting. Although it's slightly more work on the backend, this is a better/more robust API, and also avoids the svelte 5 proxy issue. Fixes podman-desktop#1304. Signed-off-by: Tim deBoer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
Similar to: #1303
Virtual Machine tab never updates past loading...
Operating system
mac M1
Version
next (development version)
Steps to reproduce
No response
Relevant log output
Additional context
No response
The text was updated successfully, but these errors were encountered: