Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose of message proxy #1263

Closed
deboer-tim opened this issue Feb 3, 2025 · 0 comments · Fixed by #1264
Closed

Dispose of message proxy #1263

deboer-tim opened this issue Feb 3, 2025 · 0 comments · Fixed by #1264
Assignees
Labels
kind/enhancement ✨ Issue for requesting an improvement
Milestone

Comments

@deboer-tim
Copy link
Contributor

Is your enhancement related to a problem? Please describe

The RPC message proxy is never disposed on shutdown. This could be the cause of podman-desktop/podman-desktop#10926, but it should be fixed either way.

Describe the solution you'd like

Dispose it properly.

Describe alternatives you've considered

No response

Additional context

No response

@deboer-tim deboer-tim added the kind/enhancement ✨ Issue for requesting an improvement label Feb 3, 2025
@deboer-tim deboer-tim self-assigned this Feb 3, 2025
@deboer-tim deboer-tim moved this to 🚧 In Progress in Podman Desktop Planning OLD Feb 3, 2025
deboer-tim added a commit to deboer-tim/podman-desktop-extension-bootc that referenced this issue Feb 3, 2025
The RPC message proxy should be disposed on shutdown. This change just disposes
it properly, and drops the timeout down to 5s (aligns with AI Lab change, may
also help with a timeout during shutdown).

Possibly the cause of
podman-desktop/podman-desktop#10926.

Fixes podman-desktop#1263.

Signed-off-by: Tim deBoer <[email protected]>
deboer-tim added a commit that referenced this issue Feb 3, 2025
The RPC message proxy should be disposed on shutdown. This change just disposes
it properly, and drops the timeout down to 5s (aligns with AI Lab change, may
also help with a timeout during shutdown).

Possibly the cause of
podman-desktop/podman-desktop#10926.

Fixes #1263.

Signed-off-by: Tim deBoer <[email protected]>
@github-project-automation github-project-automation bot moved this from 🚧 In Progress to ✔️ Done in Podman Desktop Planning OLD Feb 3, 2025
@nichjones1 nichjones1 moved this to ✔️ Done in Podman Desktop Planning Feb 5, 2025
@deboer-tim deboer-tim added this to the 1.7 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement ✨ Issue for requesting an improvement
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

1 participant