Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt code to the changes in the ui package of podman-desktop #1235

Open
benoitf opened this issue Jan 27, 2025 · 1 comment
Open

adapt code to the changes in the ui package of podman-desktop #1235

benoitf opened this issue Jan 27, 2025 · 1 comment
Assignees
Labels
kind/enhancement ✨ Issue for requesting an improvement sprint/unplanned

Comments

@benoitf
Copy link
Contributor

benoitf commented Jan 27, 2025

Is your enhancement related to a problem? Please describe

see #1228
it seems some changes in the library is producing some regression (unit tests)

Describe the solution you'd like

fix the code or then fix in upstream to be able to switch to a more recent version of the ui package

Describe alternatives you've considered

No response

Additional context

No response

@benoitf benoitf added kind/enhancement ✨ Issue for requesting an improvement good first issue Good for newcomers labels Jan 27, 2025
@deboer-tim deboer-tim self-assigned this Jan 28, 2025
@deboer-tim deboer-tim added sprint/unplanned and removed good first issue Good for newcomers labels Jan 28, 2025
@deboer-tim
Copy link
Contributor

The tests are confirming that when you're at a given route the correct item (and only that) is selected in the navigation. SettingsNavItem added an extra div in the hierarchy so it's checking the wrong one.

Ideally SettingsNavItem would have aria labels, and the test would look at more of the hierarchy - but it was only a minute to find the problem, fix the test, and add the missing test for examples. If it happens again we can do something better but for now I'll add the simple commit to unblock this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement ✨ Issue for requesting an improvement sprint/unplanned
Projects
None yet
Development

No branches or pull requests

2 participants