Skip to content

Conversation

@Floris-Pleegzorg-Oost-Vlaanderen
Copy link
Contributor

Q A
Bug fix? [ X]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1975

What's in this Pull Request?

The documentation mentions that it is possible to set the webUrl, but webUrl wasn't passed to the constructor when the constructor in ListItemAttachments creates Spservice

Add the option to pass an URL of the site.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the first contribution to this project.

@joaojmendes
Copy link
Collaborator

@Floris-Pleegzorg-Oost-Vlaanderen, Thank you for your fix.

@joaojmendes joaojmendes self-assigned this Jul 13, 2025
@joaojmendes joaojmendes added the status:fixed-next-drop Issue will be fixed in upcoming release. label Jul 13, 2025
@joaojmendes joaojmendes added this to the 3.22.0 milestone Jul 13, 2025
@joaojmendes joaojmendes merged commit cacb5cb into pnp:dev Jul 13, 2025
1 check passed
@PopWarner
Copy link
Member

🎉✨ Woohoo! ✨🎉

Thank you @Floris-Pleegzorg-Oost-Vlaanderen for your awesome contribution to the community with this merged PR! 🚀 You've earned a Credly badge through the Microsoft 365 & Power Platform Recognition Program. 🏅 To receive your badge, please take a moment to opt in to the program. You can learn more and sign up here: https://aka.ms/community/recognition.

Can't wait to see you in the program! 🎊

cc: @joaojmendes

Cheers,
David Warner 🧡💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:fixed-next-drop Issue will be fixed in upcoming release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants