Fixing issue apply TenantTemplate creating a new Team in an application context #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work when used in an application context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
Invoke-PnPTenantTemplateto create a new Team when using an application context using a clientId and certificate, the group would be created first, then teamified and then permissions would be added on the group for the owners and members. This would fail in an application context as teamifying a group requires an owner to be present first, which is not allowed to be the service principal, before doing so. In this PR we move the part of setting the owners and members from after group creation and teamification to after group creation but before teamification. This fixes this issue. Works well for both delegated as well as application contexts now.