Skip to content

Fixes external item add with custom properties. Closes #6792 #6823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes external item add with custom properties. Closes #6792 #6823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions src/m365/external/commands/item/item-add.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,11 @@ describe(commands.ITEM_ADD, () => {
"content": {
"value": "Something went wrong",
"type": "text"
},
"activities": []
}
};
sinon.stub(request, 'put').callsFake(async (opts: any) => {
const putStub = sinon.stub(request, 'put').callsFake(async (opts: any) => {
if (opts.url === `https://graph.microsoft.com/v1.0/external/connections/connection/items/ticket1`) {
return externalItem;
return;
}
throw 'Invalid request';
});
Expand All @@ -91,7 +90,7 @@ describe(commands.ITEM_ADD, () => {
assignee: 'Steve'
};
await command.action(logger, { options } as any);
assert(loggerLogSpy.calledWith(externalItem));
assert.deepStrictEqual(putStub.lastCall.args[0].data, externalItem);
});

it('adds an external item with a collection properties', async () => {
Expand All @@ -113,12 +112,11 @@ describe(commands.ITEM_ADD, () => {
"content": {
"value": "Something went wrong",
"type": "text"
},
"activities": []
}
};
sinon.stub(request, 'put').callsFake(async (opts: any) => {
const putStub = sinon.stub(request, 'put').callsFake(async (opts: any) => {
if (opts.url === `https://graph.microsoft.com/v1.0/external/connections/connection/items/ticket1`) {
return externalItem;
return;
}
throw 'Invalid request';
});
Expand All @@ -133,7 +131,7 @@ describe(commands.ITEM_ADD, () => {
assignee: 'Steve;#Brian'
};
await command.action(logger, { options } as any);
assert(loggerLogSpy.calledWith(externalItem));
assert.deepStrictEqual(putStub.lastCall.args[0].data, externalItem);
});

it('outputs properties in csv output', async () => {
Expand Down
2 changes: 1 addition & 1 deletion src/m365/external/commands/item/item-add.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ class ExternalItemAddCommand extends GraphCommand {
// we need to rewrite the @odata properties to the correct format
// to extract multiple values for collections into arrays
this.rewriteCollectionProperties(args.options);
this.addUnknownOptionsToPayload(requestBody, args.options);
this.addUnknownOptionsToPayload(requestBody.properties, args.options);

const requestOptions: CliRequestOptions = {
url: `${this.resource}/v1.0/external/connections/${args.options.externalConnectionId}/items/${args.options.id}`,
Expand Down
Loading