Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds command viva engage community user remove. Closes #6296 #6389

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MathijsVerbeeck
Copy link
Contributor

Closes #6296

@MathijsVerbeeck MathijsVerbeeck added the pr-major PR for the next major release label Sep 26, 2024
@MathijsVerbeeck MathijsVerbeeck linked an issue Sep 26, 2024 that may be closed by this pull request
@Adam-it Adam-it changed the base branch from v10 to main September 30, 2024 13:27
@MathijsVerbeeck MathijsVerbeeck force-pushed the engage-community-user-remove branch from 8997149 to 69ef4cc Compare October 2, 2024 08:55
@martinlingstuyl martinlingstuyl self-assigned this Oct 4, 2024
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MathijsVerbeeck, check out my comments on PR #6388 to fix this one as well

* @param displayName Community display name.
* @returns The ID of the Viva Engage community.
*/
async getCommunityIdByDisplayName(displayName: string): Promise<string> {
Copy link
Contributor

@martinlingstuyl martinlingstuyl Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkout my comments on the related PR for adding users

@martinlingstuyl martinlingstuyl marked this pull request as draft October 6, 2024 13:58
@Adam-it Adam-it removed the pr-major PR for the next major release label Oct 30, 2024
@Adam-it
Copy link
Member

Adam-it commented Oct 30, 2024

I am removing the pr-major label from this PR as we agreed to proceed with this change the 'standard' way and the removal of the group commands as breaking change that will target v11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: viva engage community user remove
3 participants