Skip to content

Added internalName option for spo field commands #6379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Added internalName option for spo field commands #6379

wants to merge 2 commits into from

Conversation

ktskumar
Copy link
Contributor

Closes #6249

In this PR, i have added internalName option to below commands

  • spo field get
  • spo field set
  • spo field remove

@milanholemans
Copy link
Contributor

Thank you, we'll try to review it ASAP!

@MathijsVerbeeck MathijsVerbeeck self-assigned this Nov 13, 2024
MathijsVerbeeck
MathijsVerbeeck requested changes Nov 29, 2024
View reviewed changes
@MathijsVerbeeck MathijsVerbeeck marked this pull request as draft November 29, 2024 15:22
@ktskumar ktskumar marked this pull request as ready for review December 21, 2024 04:43
@martinlingstuyl martinlingstuyl self-assigned this Feb 1, 2025
martinlingstuyl
martinlingstuyl reviewed Feb 1, 2025
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last comments

@martinlingstuyl
Copy link
Contributor

Merged manually, thank you !! 👏👏🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinlingstuyl martinlingstuyl martinlingstuyl left review comments

@MathijsVerbeeck MathijsVerbeeck MathijsVerbeeck requested changes

Assignees

@martinlingstuyl martinlingstuyl

Labels
pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add internalName option for spo field commands
4 participants
@ktskumar @milanholemans @martinlingstuyl @MathijsVerbeeck