Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends 'entra app add/set' commands with new parameter --allowPublicClientFlow. #5908

Closed

Conversation

mkm17
Copy link
Contributor

@mkm17 mkm17 commented Mar 12, 2024

Extends 'entra app add/set' commands with new parameter --allowPublicClientFlow. Closes #5870

Hi, I have added this parameter first, Then I will get the shared logic for the task described in task #1963.

Could you please confirm if the parameter configuration for the entra app set is correct? I hope everything is in order. :)

Adds --allowPublicClientFlow option to entra app add/set commands

Linked Issue #5870

Closes #5870

@martinlingstuyl
Copy link
Contributor

Thanks @mkm17! The option configuration looks fine at first sight... we'll review this asap

@mkm17 mkm17 force-pushed the issues/5870_allowPublicClientFlow_option branch from f924534 to 283f340 Compare March 13, 2024 21:59
@mkm17
Copy link
Contributor Author

mkm17 commented Mar 13, 2024

I forgot to make a rebase, so in this version should be ok.

@martinlingstuyl martinlingstuyl self-assigned this Mar 31, 2024
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mkm17, a couple of comments only...

docs/docs/cmd/entra/app/app-set.mdx Outdated Show resolved Hide resolved
src/m365/entra/commands/app/app-set.ts Show resolved Hide resolved
@martinlingstuyl martinlingstuyl marked this pull request as draft March 31, 2024 18:59
@mkm17 mkm17 force-pushed the issues/5870_allowPublicClientFlow_option branch from 283f340 to 3f4f23d Compare April 2, 2024 06:49
@mkm17 mkm17 marked this pull request as ready for review April 2, 2024 06:54
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I'll merge it soon!

@martinlingstuyl
Copy link
Contributor

Merged manually. Thank you 💪🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --allowPublicClientFlow option to entra app add/set commands
2 participants